Skip to main content

EFCore - Update command is not updating the underlying data

Why my update command using EFCore is not updating the underlying data in the database though in middle-tier code it's successful, not throwing any error?

Let's try to get the root cause and how to solve this. 

When creating the model class of related database object if the primary key name is Id then no need to explicitly mention the Key in ef-core OnModelCreating. 

But if we've key name different from Id then we have to explicitly mention it in our OnModelCreating.

Something like this:

 entity.HasKey(c => new {c.CustId });

Assume in the database we've Customers table like this:

CREATE TABLE [dbo].[Customers](
	[CustId] [INT] IDENTITY(1,1) NOT NULL Primary Key,
	[FirstName] [VARCHAR](50) NULL
)

Point to ponder: In the database table, column CustId is already defined as Primary key. 

In EFCore model setup, it's up to us to configure the Key as (custId) or configure it as HasNoKey()


Assume we've set our entity with HasNoKey()

Customer-Model-HasNoKey
  
protected override void OnModelCreating(ModelBuilder modelBuilder)
{   
	modelBuilder.Entity(entity =>
	{
		// Here we're not setting kay key to EFCore model.
		entity.HasNoKey();

		entity.Property(e => e.FirstName)
			.HasMaxLength(50)
			.IsUnicode(false);
	});
	OnModelCreatingPartial(modelBuilder);
}

  

 And executed the command to update Customers entity using  EFCore code

EfCore code snippet:

var customer = _dbContext.Customers.Where(x => x.CustId == 1).FirstOrDefault();
customer.FirstName = "Updated name - with primary key";
_dbContext.SaveChanges();

 Then trying to update the Customers entity from EFCore code base, related entries value in the database will not change.  Here is the screen is shown before & after executing the ef-core code.



Now let's try to add the primary key in Customers model and then update 

Customer-Model-HasKey

protected override void OnModelCreating(ModelBuilder modelBuilder)
{
	modelBuilder.Entity(entity =>
	{
		// define your key here.
		entity.HasKey(c => new {c.CustId });

		entity.Property(e => e.FirstName)
			.HasMaxLength(50)
			.IsUnicode(false);
	});
	OnModelCreatingPartial(modelBuilder);
}

and now execute the same EfCore code to update the customers' entity and verify in the database, yes, out data got updated. 


Conclusion:

In EFCore if it good to have primary key explicitly defined (if it's not Id) in our model, otherwise at runtime we may come across a situation like this (update not happening, sorting not working....)



Comments

Popular posts from this blog

EFCore - Collate function

Search in SQL server query is generally case insensitive (by default or based on database level collation). Suppose we have an employees table with a row having first-name column value as "My-First-Name", so if we want to do the case-sensitive search we have to explicitly use the related collate: In EF 5 (currently in Release Candidate version [RC.2.20475.6]) Collate function got introduced which helps us to use our specific collation based search.  C# with EF5 code sample: var employeeCaseSensitiveSearch = _dbContext.Employees .Where(x => EF.Functions.Collate(x.FirstName, "Latin1_General_CS_AS") == "my-first-name") .FirstOrDefault(); A related database query will be something like this: T-SQL: Case sensitive search (use specific collation e.g.: Latin1_General_CS_AS) SELECT * FROM dbo.Employees AS e WHERE e.FirstName Collate Latin1_General_CS_AS = 'my-first-name' Some of the useful CSharp function which g...

EFCore - Parallel db call on same dbContext

Practically there are multiple instances when we want to do parallel DB call which will save us some time. Like if we want to get a few employees details as well as users detail and if both entities are independent of each other better to go with a parallel call to fetch the details.  With the growing ORM usage and enhanced & optimized framework of like EFCore, in most of the application (related to C# development), we generally prefer to use EFCore. With EFCore if we try to use the same DB context to do parallel db call we are getting an error (... different thread using the same DbContext....). Because dbContext call is not thread-safe Parallel DB call on the same dbContext:  Code snipped: which will throw an error private void DbCallWithParallelCallOnSameDbContext() { try { var employeesTask = _dbContext.Employees.ToListAsync(); var usersTask = _dbContext.Users.ToListAsync(); ...

How to install Zen-coding plugin

As a web-developer, irrespective of the technologies (java, c-sharp, python, php e.t.c.…), we used to write CSS code to make our web-pages looks good if not at least we’re involved in write html codes. What if there is some tool to whom you give some instruction and that tool generates a good, well formatted html tags for you. These kind of coding is possible and known as “ Zen coding ” and there are lots of plug-in available from different vendors. We’re going to  discuss the steps to install this “zen-coding” plugin for “visual studio, eclipse, sublime-text & notepad++ in next few lines. Follow the below steps to install "zen-coding" plugin based on your editor.  Steps to install zen-coding plugin for (visual studio, eclipse, sublime-text,notepad++) -- -- For Visual Studio 1. Go to "Tools" -> "Extensions and Updates" 2. It'll open the "Extensions and Updates windows"    Select online form Left hand menu items ent...